Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 600 - Incorrect cell validation / coercion#601

Merged
Marc-Andre-Rivet merged 3 commits into
devfrom
600-delete-defaults
Sep 24, 2019
Merged

Issue 600 - Incorrect cell validation / coercion#601
Marc-Andre-Rivet merged 3 commits into
devfrom
600-delete-defaults

Conversation

@Marc-Andre-Rivet

@Marc-Andre-Rivet Marc-Andre-Rivet commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Fixes #600

The delete cell operation done through backspace on selected cells is already a bit confusing as it will delete content based on whether the column is editable or not. The additional changes to apply defaults is no less confusing but is at least it's aiming to be consistent with how the table would behave if you were to delete content for each cell individually.

Marc-André Rivet and others added 2 commits September 24, 2019 09:09
- attempt reconciliation for delete
- additional tests
- update changelog
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-601 September 24, 2019 13:11 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-601 September 24, 2019 13:12 Inactive
@Marc-Andre-Rivet
Marc-Andre-Rivet marked this pull request as ready for review September 24, 2019 13:51

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect cell validation / coercion

3 participants